Fix bidi selection #5002
Merged
Fix bidi selection #5002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Codecov ReportBase: 86.11% // Head: 86.11% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5002 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 546 546
Lines 41600 41600
Branches 6553 6553
=======================================
Hits 35822 35822
Misses 5778 5778
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you select characters in a bidi line, it selects 10x more width than required. It is because of the contatinating a 0 to a string. This pull request fixes this problem.