Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Conversation

randomnicode
Copy link
Contributor

@randomnicode randomnicode commented Dec 11, 2018

This PR is just testing grounds. Subsequent PRs will break up most of the changes here into more meaningful chunks.

Updates some libs.

The major ones are:

  • JDOM -> JDOM2 (mostly import changes)
  • EHCache 2.5 -> 3.2.3 (differences with tiered cache mechanisms, mostly localized to CacheFactory)
  • Lucene 3 -> 7.5 (some api changes, mostly localized to SearchService)
  • JFreeChart (some api changes)

@muff1nman
Copy link
Contributor

Im a bit more nervous about this as some of these I either know will break stuff or has a good probability to break things. I.e. hsql dependecy change.

With that said I think, I think we can still do this, but on these conditons:

  1. We do it next release. This release has been postponed far too long and should only accept bug fixes at this point.
  2. We break these into smaller changes. I.e. do the lucene change in one pr, some of the smaller stuff grouped into another pr.

@randomnicode
Copy link
Contributor Author

Yeah, fair enough, I think it should be a different release.
Some of these changes are not backwards-compatible (the lucene upgrade, for instance, requires rebuilding indexes).

Wanted to put this PR up to get some reviews. I will break it up into smaller changes.
Haven't started debugging hsql problems yet (seems to be breaking on enforcing the varchar size declaration).

@randomnicode randomnicode changed the title Update dependencies Update dependencies - DO NOT MERGE Dec 15, 2018
@stale
Copy link

stale bot commented Mar 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale This label will be removed soon label Mar 15, 2019
@jvoisin
Copy link
Contributor

jvoisin commented Apr 1, 2019

@randomnicode any chance you're still willing to work on this? I'd like to bump the dependencies too, maybe I can help.

@stale stale bot removed the stale This label will be removed soon label Apr 1, 2019
@jvoisin jvoisin closed this May 16, 2019
@jvoisin jvoisin mentioned this pull request Jun 9, 2019
@randomnicode
Copy link
Contributor Author

@jvoisin Sorry, I've been away. Thanks for continuing the work.

@jvoisin
Copy link
Contributor

jvoisin commented Oct 20, 2019

Glad to have you back, and happy to see that someone who actually knows what they're doing is taking this over!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants