Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Conversation

fxthomas
Copy link
Contributor

This follows #1421 by adding an up/down toggle button on the right-side of the player bar.

The toggle button is only displayed when auto-hide is not set (should it be displayed at all times?).

Play queue shown:

Screenshot from 2020-02-16 16-47-55

Play queue hidden:

Screenshot from 2020-02-16 16-47-43

@randomnicode
Copy link
Contributor

The toggle button is only displayed when auto-hide is not set (should it be displayed at all times?).

Is autohide even needed if this feature is present? We could conceivably just take it out.

@fxthomas
Copy link
Contributor Author

Is autohide even needed if this feature is present? We could conceivably just take it out.

Good idea. I personally wouldn't mind, but I think it is better if we have some input from users other than ourselves, so I created a poll here : https://www.reddit.com/r/airsonic/comments/f5yeis/poll_how_do_you_use_the_airsonic_play_queue.

@fxthomas fxthomas added the in: UNKNOWN-frontend The problem location has not been identified yet. label Feb 18, 2020
@randomnicode
Copy link
Contributor

I like this change. Could animate it too, but I'm in favor of it.

Don't have an opinion about the iconography (others more visually inclined may have better opinions), but overall this looks pretty good to me.

@eharris
Copy link
Contributor

eharris commented Mar 16, 2020

I still like having the option of auto-hide, but the toggle is a good improvement.

@jvoisin jvoisin merged commit 3f38c52 into airsonic:master Mar 16, 2020
@randomnicode
Copy link
Contributor

randomnicode commented Mar 16, 2020

A few things since this was merged on airsonic-advanced a while back.

@tesshucom tesshucom mentioned this pull request Apr 5, 2020
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in: UNKNOWN-frontend The problem location has not been identified yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants