Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Conversation

Whisprin
Copy link
Contributor

Add DeviceAllow=char-alsa rw and disable PrivateDevices to allow access to alsa hardware

Signed-off-by: Robert Sprunk <git@sprunk.me>
NoNewPrivileges=yes
PrivateDevices=yes
#PrivateDevices=yes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we were to remove this, should we directly remove it, rather than commenting-it-out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment stating that this is required for Jukebox only, similar to line 46-48: #ProtectHome=true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes a comment would be good and moved into a separate section like ProtectHome

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Whisprin can you update your PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muff1nman Updated the PR accordingly, sorry for the delay

@almet
Copy link

almet commented Nov 13, 2019

For whoever is interested, here is the systemd doc about private devices: https://www.freedesktop.org/software/systemd/man/systemd.exec.html#PrivateDevices=

@Whisprin
Copy link
Contributor Author

Whisprin commented Nov 17, 2019

Opened an issue for further discussion. With the changes proposed here I'm able to select an audio device from the Admin UI. However, it's still not possible to play music. Music playback is possible, Jukebox is just a bit crashy

@fxthomas
Copy link
Contributor

fxthomas commented Dec 4, 2019

I think we should:

  • Setup the systemd unit for all features by default
  • Comment on why these restrictions were lifted (so that interested people can re-enable them if they don't use the associated feature)

Also, what do you mean by "jukebox is a bit crashy"? Is this something that could be split in a separate issue, or is that related to the device restrictions?

@Whisprin
Copy link
Contributor Author

Whisprin commented Dec 5, 2019

Also, what do you mean by "jukebox is a bit crashy"? Is this something that could be split in a separate issue, or is that related to the device restrictions?

Yes, propably something that would go into a separate issue. I'm trying to make it reproducible and collect logs. In short: I use DSub to connect to the jukebox, music is playing, switching songs works - however, when I disconnect DSub and reconnect later: nothing is playing anymore
The only way to recover from this state is to restart Airsonic

Signed-off-by: Robert Sprunk <git@sprunk.me>
Copy link
Contributor

@fxthomas fxthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good to me now.

@fxthomas fxthomas requested a review from muff1nman December 15, 2019 16:00
@muff1nman muff1nman merged commit d063688 into airsonic:master Dec 17, 2019
@Whisprin Whisprin deleted the systemd-jukebox branch February 11, 2020 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants