Add a "Check that everything is fine" page #1457
Conversation
| map.put("indexSongCount", reader.numDocs()); | ||
| map.put("indexSongDeletedCount", reader.numDeletedDocs()); | ||
| } catch (IOException e) { | ||
| LOG.debug("Unable to gather information", e); |
There was a problem hiding this comment.
This should be changed for less generic log message :)
|
This looks amazing! |
|
Thanks 😉 I added info about ffmpeg + ffprobe in addition to a small refactoring. Now this just needs tweaking log messages, adding the correct i18n and testing on other databases (not sure if what I did works on PostgreSQL/MySQL). |
eea6a04 to
6e319c8
Compare
|
I moved a few things around, tested on PostgreSQL, added i18n and a few additional consistency checks. Should be good for review and testing now! |
|
This looks glorious, and it would be a shame to let it rot: can we merge it? |
502b4e8 to
27a3a7e
Compare
|
Thanks! I did some more tests on this to make sure it's going to be robust on recent PostgreSQL/MariaDB/MySQL versions, hope you don't mind the last minute bits:
All previous commits are the same as what you reviewed, squashed and rebased on master. |
|
With that it should be fully tested on all 3 major databases and ready to merge whenever you're okay with it. |
|
Added one more last minute fix for the last failure. Obviously I should know that saying "everything is good" before Travis runs is a huge death flag... 🤣 Not sure why it's complaining about |
|
I cleared Travis's cache, hopefully this fixes the build? Edit: It did! |
This is a first attempt with some of the ideas in #1082, implemented just like the "About" page.
It's not finished yet, but it should be functional enough for testing so I'll leave it here for comments.
Screenshot: