This repository was archived by the owner on Sep 8, 2021. It is now read-only.
Change avatar storage column to bytea for PostgreSQL #1452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mental note: we really need to add more db migration tests. |
muff1nman
approved these changes
Jan 4, 2020
In PostgreSQL, Liquibase maps the `blob` type to an `oid` column by default[1]. That column type is not supported[2] very well when using the `valueBlobFile` attribute, which expects a `bytea` column instead. This was confirmed on all PostgreSQL versions starting from 9.6. The `validCheckSum` attribute does not need to be updated since it was already for the previous (binary_type, varchar_type) combination in an unrelated commit (78a99d5). Fixes airsonic#1213. [1] https://liquibase.jira.com/browse/CORE-1863 [2] liquibase/liquibase#605
5bd841a to
66434f7
Compare
|
Rebased on master to make the build pass. |
|
ahh sorry already merged the previous version. |
|
That's okay, no worries. It shouldn't change a lot of things in the tests to be fair, since... we don't test that 😉 |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PostgreSQL, Liquibase maps the
blobtype to anoidcolumn bydefault[1]. That column type is not supported[2] very well when using
the
valueBlobFileattribute, which expects abyteacolumn instead.This was confirmed on all PostgreSQL versions starting from 9.6 (Airsonic
fails to start in all cases).
The
validCheckSumattribute does not need to be updated since it wasalready for the previous (binary_type, varchar_type) combination in
an unrelated commit (78a99d5).
Fixes #1213.
[1] https://liquibase.jira.com/browse/CORE-1863
[2] liquibase/liquibase#605