This repository was archived by the owner on Sep 8, 2021. It is now read-only.
Fix DLNA/UPNP port, and expose them in Docker #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoisin
approved these changes
Oct 31, 2019
muff1nman
suggested changes
Nov 3, 2019
airsonic-main/src/main/java/org/airsonic/player/service/UPnPService.java
Outdated
Show resolved
Hide resolved
|
@muff1nman moved port to SettingsService |
fxthomas
reviewed
Nov 10, 2019
| @@ -290,6 +292,10 @@ private static String getFileSystemAppName() { | |||
| public static String getDefaultJDBCurl("") { | |||
| return "jdbc:hsqldb:file:" + getAirsonicHome().getPath() + "/db/" + getFileSystemAppName(); | |||
| } | |||
|
|
|||
| public static int getDefaultUPnpPort() { | |||
| return Optional.ofNullable(System.getProperty("UPNP_PORT")).map(x -> Integer.parseInt(x)).orElse(DEFAULT_UPNP_PORT); | |||
There was a problem hiding this comment.
For consistency with all other settings, could you use the same kind of casing (e.g. UpnpPort) as the other keys and store it at the top of the file in a constant?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to and possible fix for #1379
UPNP_PORTjava -DUPNP_PORT=4042 -jar airsonic.warNote that if the default port is modified using
UPNP_PORT, then user needs to expose and bind the custom port manually if running a container.