Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Allow previous Liquibase migration checksums for MariaDB #1352

Conversation

fxthomas
Copy link
Contributor

If someone was using MariaDB before #1188, they were probably doing so by using the MySQL JDBC driver to pass the migration (which had the proper workarounds in place for some column types).

This commit assumes that the migrations done that way were valid and produced the same result as running the MariaDB migrations after #1188.

This should fix #1333.

@muff1nman
Copy link
Contributor

Excellent work @fxthomas. Maybe we can get one other person to confirm and then we should merge asap.

@eharris eharris added the in: UNKNOWN-backend The problem location has not been identified yet. label Oct 21, 2019
@Neogrey
Copy link

Neogrey commented Oct 21, 2019

@fxthomas thanks for your work. As mentioned in #1333, I replaced with docker cp the airsonic.war with yours https://github.com/fxthomas/airsonic/releases/tag/10.4.1-fix-1333. But seems the issue still exist for me: airsonic_10_4_1_fix.log.

If someone was using MariaDB before airsonic#1188, they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).

This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after airsonic#1188.
@fxthomas fxthomas force-pushed the 1333-allow-previous-migration-checksums-for-mariadb branch from 95db085 to 78a99d5 Compare October 21, 2019 20:00
@fxthomas
Copy link
Contributor Author

Ah, well, shoot, there were more changes not shown in the previous log! I'll make a new build in a sec, let me know if that one works for you.

@fxthomas
Copy link
Contributor Author

Done : can you download https://github.com/fxthomas/airsonic/releases/tag/10.4.1-fix-1333 again and test it?

@Neogrey
Copy link

Neogrey commented Oct 21, 2019

Thanks a lot!, now it works: airsonic_10_4_1_fix2.log

@fxthomas
Copy link
Contributor Author

Great, thank you for the quick updates! 😄

@chaosbiber
Copy link

Fixed validation errors for me as well.
Btw. should we update the jdbc connection string for MariaDB? I'm still using the mysql driver.

@fxthomas
Copy link
Contributor Author

Thank you!

I don't use MariaDB/MySQL, so I cannot vouch for it unfortunately... That being said using the MariaDB driver for MariaDB is probably the safest, as they are developed together, right?

@fxthomas fxthomas merged commit 320e2a7 into airsonic:master Oct 22, 2019
@fxthomas fxthomas deleted the 1333-allow-previous-migration-checksums-for-mariadb branch October 22, 2019 18:27
@fxthomas fxthomas mentioned this pull request Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in: UNKNOWN-backend The problem location has not been identified yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10.4.0 -> 10.4.1: 404 Not found after Update
5 participants