This repository was archived by the owner on Sep 8, 2021. It is now read-only.
Disallow deleting your own user or removing admin role #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoisin
approved these changes
Jun 15, 2019
|
Shouldn't there also be a server side check here as well? |
3bbb0db to
d1598db
Compare
d1598db to
983d688
Compare
|
@muff1nman I added validation to reject these on the server side too. Didn't bother with translations for the error messages since users won't even be given the option with the prior changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes no sense and is potentially dangerous to allow a user to delete their own account, or to be able to remove the admin role from themselves, so this removes the ability to do so.