Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Enable additional checkstyles for whitespace #1197

Merged
merged 3 commits into from
Aug 11, 2019

Conversation

eharris
Copy link
Contributor

@eharris eharris commented Aug 8, 2019

No description provided.

@tesshucom
Copy link
Contributor

@eharris

I like this approach.
I think eharris knows well and has worked hard.

Speaking dare, I think that checkstyle discussions and immediate code correction are not necessary in the individual issues review before such rules are added in advance.
Because the issus conversation will be unnecessarily long.

The intention of the update can be grasped by such a history that the code is naturally corrected with checkstyle merge.
I think the silent checkstyle update process contributes greatly to the quality of reviews.

@eharris eharris force-pushed the checkstyle-whitespace branch from 66f56f3 to cf2e680 Compare August 8, 2019 22:28
@jvoisin jvoisin merged commit f738819 into airsonic:master Aug 11, 2019
@eharris eharris deleted the checkstyle-whitespace branch August 12, 2019 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants