Cleaned up the logging and experimental things I added, I think it's good now.

Also looks like you'll need to add an explicit depdency for the following:

[WARNING] Used undeclared dependencies found:
[WARNING]    com.google.code.findbugs:jsr305:jar:3.0.2:compile

Should just be able to put it in the airsonic-main/pom.xml.

I'll pull that and leave it running on my server for a while, I'll let you guys know if I see something going bad!

Wrote some tests for this in #1026. With this PR the responses now actually line up with ffmpeg's generated output. Well done!

Besides getting travis to be happy, I'd like to see this PR reduced to the minimum amount of changes possible. I.e. no line changes, no refactoring, etc. Those can be done separately if really needed. The reason for this is two fold:

1. This is a critical part of code and the smaller amount of changes we can make the easier it is to understand the impacts.
2. A smaller changeset is easier to revert if necessary.

@tari let me know your thoughts on simplifying. I'd also be more than happy to send a PR against your PR to help.

I mentioned I had been getting this issue lately in #685 (comment), but the current PR unfortunately doesn't appear to fix it, it just makes it appear 100% of the time on one specific album/song.

1. Go to Airsonic and click on "Play Album". The first song plays.
2. Wait till the end.
3. The play queue appears to go to the second song, but the playback stops.

The player looks like this when this happens (note the "Live Broadcast"):

The Firefox logs contain this message (and the stream request appears incomplete in the Network panel):

AbortError: The fetching process for the media resource was aborted by the user agent at the user's request.

Here are file sizes and durations (as reported by ffprobe):

• FLAC: 00:03:08.03
• Manual transcode using the same command as the logs: 7521175 bytes, 00:03:08.03
• Manual stream with curl (using Firefox' handy 'Copy as cURL', so this should be exactly the same request): 7520000 bytes, 00:03:08.00 (mp3check reports "130 bytes missing from last frame")
• After your PR, manual stream with curl: 7521175 bytes, 00:03:08.03

@fxthomas can you send me your example file?

Sure, in your mailbox!

In the mean time, it seems that I'm just a poor dumb human making mistakes. I restarted Firefox, which made the issue go away with your PR. I also happened to take the wrong notes for the stream size/duration after PR, edited my earlier comment to reflect that. All I can say is... great job on the PR! 😄

As for reducing the impact of these changes overall, I think the refactoring is necessary for everything to make sense (without it, it's very difficult to follow what should happen) but much of the reformatting and other changes could be split up. I'll do some rebasing so refactoring and reformatting are more separate, but if you have further opinions on simplification I'm happy to see them.

..and now it's been split into a number of smaller commits.

How exciting! Thanks team!

Most excellent 👌