This repository was archived by the owner on Sep 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 238
This repository was archived by the owner on Sep 8, 2021. It is now read-only.
Do we want to add more checks in checkstyle? #1121
Copy link
Copy link
Open
Labels
for: team-attentionAn issue we need to discuss as a team to make progress.An issue we need to discuss as a team to make progress.staleThis label will be removed soonThis label will be removed soonstatus: ideal-for-contributionAn issue that a contributor can help us with.An issue that a contributor can help us with.
Description
Currently, we're only using RedundantImport and UnusedImports in checkstyle, but there are a lot of other interesting checks available, like:
- EmptyLineSeparator — Enable several more checkstyle modules #1196
- EqualsAvoidNull — Enable EqualsAvoidNull in checkstyle #1183
- EqualsHashCode — 167d1d9
- FileTabCharacter — Enable checkstyle FileTabCharacter #1206
- FinalLocalVariable
- Indentation — Enable checkstyle's Indentation module #1194
- MethodParamPad — Enable additional checkstyles for whitespace #1197
- ModifiedControlVariable
- NoWhiteSpaceBefore — Enable additional checkstyles for whitespace #1197
- OneStatementPerLine — Enable checkstyle OneStatementPerLine #1201
- ParenPadCheck — Enable several more checkstyle modules #1196
- SimplifyBooleanExpression — Enable checkstyle for simple boolean expressions #1200
- SimplifyBooleanReturn — Enable checkstyle for simple boolean expressions #1200
- StringLiteralEquality — 10b4116
- TypecastParenPad — Enable several more checkstyle modules #1196
- UniqueProperties — Enable checkstyle UniqueProperties #1205
- WhiteSpaceAround — Enable additional checkstyles for whitespace #1197
- …
How do we feel about enabling some of them? If so, which ones?
Metadata
Metadata
Assignees
Labels
for: team-attentionAn issue we need to discuss as a team to make progress.An issue we need to discuss as a team to make progress.staleThis label will be removed soonThis label will be removed soonstatus: ideal-for-contributionAn issue that a contributor can help us with.An issue that a contributor can help us with.