Skip to content

Fix blinking issue when loop the animation in minFrame and maxFrame #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2024
Merged

Fix blinking issue when loop the animation in minFrame and maxFrame #2497

merged 1 commit into from
Oct 27, 2024

Conversation

yunlinos
Copy link
Contributor

I encount blinking issue with a company internal resource.

Problem reproduction steps：

  1. setMinAndMaxFrame(m, n) and repeatCount = INFINITE
  2. it will notifyUpdate when animation ended, but the frame has not been reset to minFrame at this time.
  3. so it will draw n+1 frame.

gpeal
gpeal reviewed Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@gpeal gpeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Sorry for not reviewing this for so long. For some reason, the CI checks didn't trigger. Can you push an empty commit or rebase/merge master and push to trigger CI?

@gpeal
Copy link
Collaborator

gpeal commented Aug 2, 2024

@yunlinos Do you want to update this?

@gpeal gpeal merged commit 211982e into airbnb:master Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpeal gpeal gpeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunlinos @gpeal