feat: route ingress traffic based on chart version #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support backwards compatibility for webapp routing between v1 and v2+ charts. In v1 charts, the webapp is served from a dedicated webapp service, while in v2+ charts the webapp is served directly from the server service. - Add chart version parameter to Ingress function - Add version-specific routing logic - Add test coverage for version boundaries and routing behavior
bernielomax
commented
Aug 7, 2025
| var pathType = networkingv1.PathType("Prefix") | ||
| func ingressRules(chartVersion string, host string) networkingv1.IngressRule { | ||
| rules := ingressRulesForV1() | ||
| if helm.ChartIsV2Plus(chartVersion) { |
There was a problem hiding this comment.
For this we probably want to be checking against Airbyte versions? That's not something we currently do, or truly support.
bgroff
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support backwards compatibility for webapp routing between v1 and v2+ charts. In v1 charts, the webapp is served from a dedicated webapp service, while in v2+ charts the webapp is served directly from the server service.