refactor: image-manifest command uses service manager client factory #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bernielomax
commented
Jul 17, 2025
- This refactor moves the service manager client factory from the local package to the service package.
- Removing the potential circular dependency (by moving FindImagesFromChart to the helm package) was a required precursor to this change, and also paves the way for implementing v1/v2 chart compatibility.
- Centralizing the factory in the service package allows manifest commands, etc to share the factory definitions. Which is consistent with the local install command and improves testability.
Move FindImagesFromChart from the images package to the helm package to avoid future circular dependency issues, since downstream packages like service use this function. This function is Helm-related, so it makes more sense for it to live in the helm package. The manifest command tests previously covered cmd.findAirbyteImages; these tests have now been moved to where the exported FindImagesFromChart function resides.
Now that circular dependency issues have been resolved by moving FindImagesFromChart to the helm package, the service manager client factory can be shared more broadly. The manifest commands and other consumers can now use a single factory for dependency injection. Placing SvcMgrClientFactory in the service package centralizes client initialization logic and avoids future dependency issues.
bernielomax
commented
Jul 17, 2025
| return nil, err | ||
| } | ||
|
|
||
| rel, err := client.InstallChart(context.TODO(), &goHelm.ChartSpec{ |
There was a problem hiding this comment.
The only change from the original function (apart from Helm client dependency injection) is replacing local template rendering (TemplateChart) with InstallChart in dry-run mode.
TemplateChartuses local rendering, which does not talk to Kubernetes and can clear or ignore the client’s discovered capabilities, requiring a throwaway Helm client to avoid issues.InstallChart(withDryRun: true) connects to the cluster, preserves discovered capabilities, and uses them when rendering. Something not possible with local rendering.
perangel
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.