refactor: restructure packages #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why CI is failing. Everything looks Ok locally. I'll have a look tomorrow. |
8851e0e to
780aa8a
Compare
780aa8a to
d437d37
Compare
|
@colesnodgrass this PR should be good to go. Hope you don't mind the changes. I kept going in circles between |
colesnodgrass
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These refactors address package organization issues that contradict Go standards. Currently, shared utilities like
helm,k8s,docker, andairbyteare nested underinternal/cmd/local/which makes them command-specific when they should be available to any command. This also prepares for eliminating the stutteringinternal/cmd/local/local/structure.Changes in this PR:
internal/cmd/local/{helm,k8s,docker,airbyte,paths}/tointernal/packagesinternal/cmd/local/localerr.LocalErrortointernal/abctl.Errorinternal/cmd/local/local/tointernal/cmd/local/which IMO causes confusion, and does not provide ample separation between domains.