Skip to content

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Feb 16, 2025

What do these changes do?

The place the in-tree cache action with an external one — https://github.com/re-actors/cache-python-deps.

Are there changes in behavior for the user?

Nope.

Related issue number

This is a follow-up for #622.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modifications, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep the list in alphabetical order, the file is sorted by name.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz force-pushed the maintenance/reusable-cache-python-deps branch from 5a62871 to 0f53587 Compare February 17, 2025 00:24
@webknjaz webknjaz self-assigned this Feb 17, 2025
@webknjaz webknjaz added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Feb 17, 2025
@webknjaz webknjaz force-pushed the maintenance/reusable-cache-python-deps branch from 0f53587 to 245cc9a Compare February 17, 2025 00:25
@webknjaz webknjaz marked this pull request as ready for review February 17, 2025 00:25
@webknjaz webknjaz force-pushed the maintenance/reusable-cache-python-deps branch from 245cc9a to 9d6b7ba Compare February 17, 2025 00:27
@webknjaz webknjaz merged commit ddddf23 into aio-libs:master Feb 17, 2025
40 checks passed
webknjaz added a commit to webknjaz/ansible--awx-plugins that referenced this pull request Feb 26, 2025
This action generalizes a piece of code for ABI-sensitive cache
management that we were copying around. It also handles corner cases
better than `actions/setup-python`.

Refs:
* https://github.com/marketplace/actions/cache-python-deps
* https://github.com/re-actors/cache-python-deps
* aio-libs/frozenlist#622
* aio-libs/frozenlist#633
* actions/setup-python#1034
* cherrypy/cheroot#739
webknjaz added a commit to sphinx-contrib/sphinxcontrib-towncrier that referenced this pull request Feb 27, 2025
This action generalizes a piece of code for ABI-sensitive cache
management that we were copying around. It also handles corner cases
better than `actions/setup-python`.

Refs:
* https://github.com/marketplace/actions/cache-python-deps
* https://github.com/re-actors/cache-python-deps
* aio-libs/frozenlist#622
* aio-libs/frozenlist#633
* actions/setup-python#1034
* cherrypy/cheroot#739
webknjaz added a commit to ansible/awx_plugins.interfaces that referenced this pull request Mar 4, 2025
This action generalizes a piece of code for ABI-sensitive cache
management that we were copying around. It also handles corner cases
better than `actions/setup-python`.

Refs:
* https://github.com/marketplace/actions/cache-python-deps
* https://github.com/re-actors/cache-python-deps
* aio-libs/frozenlist#622
* aio-libs/frozenlist#633
* actions/setup-python#1034
* cherrypy/cheroot#739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant