Skip to content

[3.5] Integrate trustme fake CA lib for testing TLS #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2019
Merged

[3.5] Integrate trustme fake CA lib for testing TLS #3489

merged 1 commit into from
Jan 5, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jan 5, 2019

Also:

  • Use real TLS context where it's disabled in tests
  • Add a change note about trustme integration

Closes #3487.
(cherry picked from commit c180800)

Co-authored-by: Sviatoslav Sydorenko wk@sydorenko.org.ua

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz @asvetlov
[3.5] Integrate trustme fake CA lib for testing TLS
1109f33 
Also:
* Use real TLS context where it's disabled in tests
* Add a change note about trustme integration

Closes #3487.
(cherry picked from commit c180800)

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
@asvetlov asvetlov requested a review from webknjaz as a code owner January 5, 2019 13:39
@codecov-io
Copy link

codecov-io commented Jan 5, 2019 •
edited
Loading

Codecov Report

Merging #3489 into 3.5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              3.5    #3489   +/-   ##
=======================================
  Coverage   97.95%   97.95%           
=======================================
  Files          44       44           
  Lines        8553     8553           
  Branches     1377     1377           
=======================================
  Hits         8378     8378           
  Misses         71       71           
  Partials      104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7e642...1109f33. Read the comment docs.

@asvetlov asvetlov merged commit 08a6902 into 3.5 Jan 5, 2019
@asvetlov asvetlov deleted the backport-c180800-3.5 branch January 5, 2019 14:47
@lock
Copy link

lock bot commented Jan 5, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 5, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asvetlov @codecov-io @webknjaz