Deprecate bare connector close #3417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3417 +/- ##
==========================================
+ Coverage 97.94% 97.95% +<.01%
==========================================
Files 44 44
Lines 8522 8543 +21
Branches 1383 1383
==========================================
+ Hits 8347 8368 +21
Misses 74 74
Partials 101 101
Continue to review full report at Codecov.
|
webknjaz
reviewed
Dec 1, 2018
| @@ -82,6 +82,10 @@ def noop(*args, **kwargs): # type: ignore | |||
| return # type: ignore | |||
|
|
|||
|
|
|||
| async def noop2(*args: Any, **kwargs: Any) -> None: | |||
There was a problem hiding this comment.
Let's rename it to represent the intent:
Suggested change
| async def noop2(*args: Any, **kwargs: Any) -> None: | |
| async def async_noop(*args: Any, **kwargs: Any) -> None: |
There was a problem hiding this comment.
- Both noops are async.
- I don't care too much, the function is internal and will be removed in aiohttp 4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
async with connector:andawait connector.close()instead