[PR #11301/815901f6 backport][3.12] Clean up redundant code and stale comments from PR #11290 #11318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #11301 as merged into master (815901f).
What do these changes do?
This PR addresses review comments from PR #11290 by:
IOBasePayload.size
property - the exceptions are already handled by the outer try-exceptAre there changes in behavior for the user?
No behavioral changes. This is purely a code cleanup that removes redundancy while maintaining the exact same functionality.
Is it a substantial burden for the maintainers to support this?
No, this actually reduces maintenance burden by:
Related issue number
Follow-up to #11290 (addressing review comments)
Related to #11270 (original bug fix)
Checklist
CONTRIBUTORS.txt
CHANGES/
folderSummary of Changes
1. Removed redundant code in
aiohttp/payload.py
:The inner try-except was redundant because:
size
property already catchesAttributeError
andOSError
self._value.tell()
will be caught by the outer handler2. Updated test comments in
tests/test_payload.py
:test_iobase_payload_size_after_reading
3. Updated test comments in
tests/test_client_functional.py
:test_file_upload_307_308_redirect
from "demonstrates the bug" to "verifies that file payloads maintain correct Content-Length"All tests continue to pass, confirming the redundant code was indeed unnecessary.