[PR #11271/331c9892 backport][3.12] Update a regex in test_aiohttp_request_coroutine for Python 3.14 #11302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) (cherry picked from commit 331c989)
5 tasks
CodSpeed Performance ReportMerging #11302 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.12 #11302 +/- ##
==========================================
- Coverage 98.32% 98.31% -0.01%
==========================================
Files 132 132
Lines 43679 43679
Branches 2384 2384
==========================================
- Hits 42946 42943 -3
- Misses 558 561 +3
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #11271 as merged into master (331c989).
What do these changes do?
Based on downstream testing in Fedora Rawhide, the expected message associated with the
TypeErrorintest_aiohttp_request_coroutinehas changed for Python 3.14, which results in a test regression on Python 3.14.This PR conditionalizes the message regex on the Python interpreter version, fixing the regression.
This can’t easily be reproduced in a virtualenv yet: I have to work around Pydantic and uvloop not being installable for Python 3.14, and even after that,
pytestsegfaults. However, I have tested the patch with Python 3.14 in Fedora.Are there changes in behavior for the user?
No; users running tests on Python 3.14 will see one fewer failure.
Is it a substantial burden for the maintainers to support this?
No. It may be desirable to remove the
if/elseand the old regex once Python 3.14 is the oldest supported Python version.Related issue number
N/A
Checklist
CONTRIBUTORS.txtThis was an awfully trivial change, but OK.CHANGES/folder