Skip to content

Bump the minimum supported version of aiosignal to 1.4 #11280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2025
Merged

Bump the minimum supported version of aiosignal to 1.4 #11280

merged 4 commits into from
Jul 7, 2025

Conversation

Dreamsorcerer
Copy link
Member

As type annotations have changed in 1.4.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 7, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (c106c5b) to head (b1acfe4).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11280   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         131      131           
  Lines       43262    43262           
  Branches     2327     2327           
=======================================
  Hits        42761    42761           
  Misses        346      346           
  Partials      155      155
Flag Coverage Δ
CI-GHA 98.73% <ø> (ø)
OS-Linux 98.46% <ø> (ø)
OS-Windows 96.79% <ø> (-0.02%) ⬇️
OS-macOS 97.68% <ø> (-0.01%) ⬇️
Py-3.10.11 97.33% <ø> (-0.01%) ⬇️
Py-3.10.18 97.65% <ø> (-0.17%) ⬇️
Py-3.11.13 98.00% <ø> (ø)
Py-3.11.9 97.52% <ø> (-0.01%) ⬇️
Py-3.12.10 97.62% <ø> (-0.01%) ⬇️
Py-3.12.11 97.51% <ø> (-0.60%) ⬇️
Py-3.13.3 98.36% <ø> (-0.01%) ⬇️
Py-3.9.13 97.21% <ø> (-0.02%) ⬇️
Py-3.9.23 97.69% <ø> (ø)
Py-pypy7.3.16 87.73% <ø> (-7.24%) ⬇️
VM-macos 97.68% <ø> (-0.01%) ⬇️
VM-ubuntu 98.46% <ø> (ø)
VM-windows 96.79% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11280 will not alter performance

Comparing bump-min-aiosignal (8e9188f) with master (c106c5b)

Summary

✅ 59 untouched benchmarks

@Dreamsorcerer Dreamsorcerer added backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot labels Jul 7, 2025
@Dreamsorcerer Dreamsorcerer merged commit 91108c9 into master Jul 7, 2025
39 checks passed
@Dreamsorcerer Dreamsorcerer deleted the bump-min-aiosignal branch July 7, 2025 20:07
@patchback Patchback
Copy link
Contributor

patchback bot commented Jul 7, 2025 •
edited
Loading

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/91108c905f6265bd19e8d1aafbaf2826a33180d2/pr-11280

Backported as #11281

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 7, 2025
@Dreamsorcerer @patchback
Bump the minimum supported version of aiosignal to 1.4 (#11280)
82f129d 
(cherry picked from commit 91108c9)
@patchback Patchback
Copy link
Contributor

patchback bot commented Jul 7, 2025 •
edited
Loading

Backport to 3.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.13/91108c905f6265bd19e8d1aafbaf2826a33180d2/pr-11280

Backported as #11282

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jul 7, 2025
Merged
patchback bot pushed a commit that referenced this pull request Jul 7, 2025
@Dreamsorcerer @patchback
Bump the minimum supported version of aiosignal to 1.4 (#11280)
22f6fcf 
(cherry picked from commit 91108c9)
@patchback patchback bot mentioned this pull request Jul 7, 2025
Merged
Dreamsorcerer added a commit that referenced this pull request Jul 7, 2025
@patchback @Dreamsorcerer
[PR #11280/91108c90 backport][3.13] Bump the minimum supported versio…
5f4b36c 
…n of aiosignal to 1.4 (#11282)

**This is a backport of PR #11280 as merged into master
(91108c9).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Jul 7, 2025
@patchback @Dreamsorcerer
[PR #11280/91108c90 backport][3.12] Bump the minimum supported versio…
0389371 
…n of aiosignal to 1.4 (#11281)

**This is a backport of PR #11280 as merged into master
(91108c9).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dreamsorcerer