[PR #11129/c0449bb5 backport][3.12] Add preemptive authentication support to DigestAuthMiddleware #11131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c0449bb)
bdraco
approved these changes
Jun 4, 2025
CodSpeed Performance ReportMerging #11131 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.12 #11131 +/- ##
==========================================
+ Coverage 98.27% 98.29% +0.01%
==========================================
Files 132 132
Lines 42703 42908 +205
Branches 2342 2357 +15
==========================================
+ Hits 41968 42176 +208
+ Misses 560 557 -3
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #11129 as merged into master (c0449bb).
What do these changes do?
It was discovered that
DigestAuthMiddlewaredoesn't work for some servers because the original implementation didn't implement preemptive support.This PR adds preemptive authentication support to
DigestAuthMiddleware, following RFC 7616 Section 3.6. The middleware now remembers successful authentication challenges and automatically includes the Authorization header in subsequent requests to the same protection space.Key changes:
preemptiveparameter toDigestAuthMiddlewareconstructor (default:True)domainparameter from server challengesdomainis specified, the entire origin becomes the protection spacestaleparameter to handle expired noncesAre there changes in behavior for the user?
Yes, but backwards compatible:
preemptive=False)Related issue number
Fixes #11128