-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Downgrade connector close error to debug #11114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is going to be expected with TLS 1.3. Error is too aggressive for something that is expected to happen. fixes #11113
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11114 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 129 129
Lines 41763 41763
Branches 2245 2245
=======================================
Hits 41276 41276
Misses 337 337
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11114 will not alter performanceComparing Summary
|
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 758738e on top of patchback/backports/3.12/758738ed4d2a3c3d2c74b9d8ba217c7141af1a16/pr-11114 Backporting merged PR #11114 into master
🤖 @patchback |
Backport to 3.13: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 758738e on top of patchback/backports/3.13/758738ed4d2a3c3d2c74b9d8ba217c7141af1a16/pr-11114 Backporting merged PR #11114 into master
🤖 @patchback |
(cherry picked from commit 758738e)
(cherry picked from commit 758738e)
@@ -0,0 +1 @@ | |||
Downgraded the logging level for connector close errors from ERROR to DEBUG, as these are expected behavior with TLS 1.3 connections -- by :user:`bdraco`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, is it not expected that 1.3 connections close correctly? I thought it was badly implemented servers that don't close the connection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed here. This seems like a bad idea. It's basically suppressing a log entry that is alerting you to 100ms additional latency added by the server not sending it's close_notify.
What do these changes do?
Downgrade connector close error to debug
This is going to be expected with TLS 1.3. Error is too aggressive for something that is expected to happen.
Also send the message to the client_logger as the original PR (#3733) sent it to the root logger which was likely not intended
Are there changes in behavior for the user?
We never logged this before we backported waiting for connection closed in #11077 so there is likely no reason to log this at error level as there is nothing that can be done about it. Its purely needed for debugging.
fixes #11113
Is it a substantial burden for the maintainers to support this?
no