Skip to content

Conversation

Tasssadar
Copy link
Contributor

Backport of #11150

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 6, 2025
@Tasssadar Tasssadar changed the title [PR #11150/996ad00 backport][3.13] [3.13] fix: leak of aiodns.DNSResolver when ClientSession is closed [PR #11150/996ad00 backport][3.12] fix: leak of aiodns.DNSResolver when ClientSession is closed Jun 6, 2025
…olver when ClientSession is closed (aio-libs#11150)

Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 996ad00)
@Tasssadar Tasssadar force-pushed the patchback/backports/3.12/996ad00037d9e729aa58b757099dd2fea5e7dcc9/pr-11150 branch from f4e29c0 to 0284e85 Compare June 6, 2025 12:07
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (c0e04a2) to head (0284e85).
Report is 1 commits behind head on 3.12.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.12   #11152      +/-   ##
==========================================
- Coverage   98.29%   98.29%   -0.01%     
==========================================
  Files         132      132              
  Lines       42990    43015      +25     
  Branches     2367     2368       +1     
==========================================
+ Hits        42258    42280      +22     
- Misses        557      560       +3     
  Partials      175      175              
Flag Coverage Δ
CI-GHA 98.17% <100.00%> (-0.01%) ⬇️
OS-Linux 97.92% <100.00%> (-0.01%) ⬇️
OS-Windows 95.60% <100.00%> (-0.01%) ⬇️
OS-macOS 97.16% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.93% <100.00%> (+<0.01%) ⬆️
Py-3.10.17 97.43% <100.00%> (+<0.01%) ⬆️
Py-3.11.12 97.60% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.11% <100.00%> (-0.01%) ⬇️
Py-3.12.10 97.95% <100.00%> (-0.01%) ⬇️
Py-3.13.3 97.94% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.83% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.32% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 88.95% <100.00%> (-1.37%) ⬇️
VM-macos 97.16% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.92% <100.00%> (-0.01%) ⬇️
VM-windows 95.60% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 6, 2025

CodSpeed Performance Report

Merging #11152 will degrade performances by 10.08%

Comparing Tasssadar:patchback/backports/3.12/996ad00037d9e729aa58b757099dd2fea5e7dcc9/pr-11150 (0284e85) with 3.12 (c0e04a2)

Summary

❌ 1 (👁 1) regressions
✅ 58 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_one_hundred_simple_get_requests_no_session[pyloop] 79.7 ms 88.6 ms -10.08%

@bdraco
Copy link
Member

bdraco commented Jun 7, 2025

Thanks @Tasssadar

I'll work on getting a release done shortly

@bdraco bdraco merged commit c1eea5e into aio-libs:3.12 Jun 7, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants