Skip to content

[PR #11150/996ad00 backport][3.13] fix: leak of aiodns.DNSResolver when ClientSession is closed #11151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

[PR #11150/996ad00 backport][3.13] fix: leak of aiodns.DNSResolver when ClientSession is closed #11151

merged 1 commit into from
Jun 7, 2025
+41 −8

Conversation

Tasssadar
Copy link
Contributor

Backport of #11150

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 6, 2025
@Tasssadar Tasssadar changed the base branch from master to 3.13 June 6, 2025 12:00
@Tasssadar Tasssadar changed the title [PR #11150/996ad00 backport][3.13] fix: leak of aiodns.DNSResolver when ClientSession is closed (#11150) [PR #11150/996ad00 backport][3.13] fix: leak of aiodns.DNSResolver when ClientSession is closed Jun 6, 2025
@Tasssadar @bdraco
[PR aio-libs#11150/996ad00 backport][3.13] fix: leak of aiodns.DNSRes…
a1e78e9 
…olver when ClientSession is closed

Co-authored-by: J. Nick Koston <nick@koston.org>
(cherry picked from commit 996ad00)
@Tasssadar Tasssadar force-pushed the patchback/backports/3.13/996ad00037d9e729aa58b757099dd2fea5e7dcc9/pr-11150 branch from 6f26600 to a1e78e9 Compare June 6, 2025 12:07
@codecov Codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.29%. Comparing base (5991031) to head (a1e78e9).
⚠️ Report is 189 commits behind head on 3.13.

Additional details and impacted files 
@@            Coverage Diff             @@
##             3.13   #11151      +/-   ##
==========================================
- Coverage   98.29%   98.29%   -0.01%     
==========================================
  Files         132      132              
  Lines       42990    43015      +25     
  Branches     2366     2367       +1     
==========================================
+ Hits        42258    42280      +22     
- Misses        557      560       +3     
  Partials      175      175
Flag Coverage Δ
CI-GHA 98.17% <100.00%> (-0.01%) ⬇️
OS-Linux 97.92% <100.00%> (-0.01%) ⬇️
OS-Windows 95.60% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.17% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.93% <100.00%> (+<0.01%) ⬆️
Py-3.10.17 97.42% <100.00%> (-0.01%) ⬇️
Py-3.11.12 97.57% <100.00%> (-0.04%) ⬇️
Py-3.11.9 97.11% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.95% <100.00%> (+<0.01%) ⬆️
Py-3.13.3 97.94% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.83% <100.00%> (+<0.01%) ⬆️
Py-3.9.22 97.32% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 94.41% <100.00%> (+4.42%) ⬆️
VM-macos 97.17% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.92% <100.00%> (-0.01%) ⬇️
VM-windows 95.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11151 will degrade performances by 10.19%

Comparing Tasssadar:patchback/backports/3.13/996ad00037d9e729aa58b757099dd2fea5e7dcc9/pr-11150 (a1e78e9) with 3.13 (5991031)

Summary

❌ 1 (👁 1) regressions
✅ 58 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_one_hundred_simple_get_requests_no_session[pyloop] 79.4 ms 88.5 ms -10.19%

@bdraco
Copy link
Member

bdraco commented Jun 7, 2025

Thanks @Tasssadar

@bdraco bdraco merged commit 834ea61 into aio-libs:3.13 Jun 7, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tasssadar @bdraco