Provide more accurate information on what eventloops are supported on windows #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 3 3
Lines 374 374
Branches 29 29
=======================================
Hits 351 351
Misses 14 14
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I looked into the packaging metadata and realized it's not marked as a dependency. Seems like it should be, with an env marker, to be conditional. |
|
With the latest pycares it's no longer required though. Not sure how that can be expressed in the metadata. |
|
Ah, I didn't realize that. You can't exactly express it through metadata. |
saghul
approved these changes
Jun 10, 2025
bdraco
approved these changes
Jun 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This project uses
winloopbut the documentation contains no mention of that and might force users to only use theasyncio.SelectorEventLoopPolicywhich can cause some confusion for users who might want to use winloop.Are there changes in behavior for the user?
Only behavior changed is documentation.
Related issue number
Checklist