Fix return type signature for CNAME and SOA records #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dreamsorcerer
approved these changes
Jun 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 3 3
Lines 374 374
Branches 29 29
=======================================
Hits 351 351
Misses 14 14
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
If we wanted to be more specific than Any I think we could make something like this, though the Any is probably fine enough. I am not familiar enough with intrinsics of overload QueryResult = Union[
asyncio.Future[list[pycares.ares_query_a_result]],
asyncio.Future[list[pycares.ares_query_aaaa_result]],
asyncio.Future[list[pycares.ares_query_caa_result]],
asyncio.Future[pycares.ares_query_cname_result],
asyncio.Future[list[pycares.ares_query_mx_result]],
asyncio.Future[list[pycares.ares_query_naptr_result]],
asyncio.Future[list[pycares.ares_query_ns_result]],
asyncio.Future[list[pycares.ares_query_ptr_result]],
asyncio.Future[pycares.ares_query_soa_result],
asyncio.Future[list[pycares.ares_query_srv_result]],
asyncio.Future[list[pycares.ares_query_txt_result]],
] |
Technically, yes, but it'd be cleaner to define a base class in pycares with the common parts. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes the return type signature of DNSResolver query to not lie to users about what is returned. Properly reflects what Pycares actually returns for each query type.
Are there changes in behavior for the user?
Return type signature now matches reality of what is returned
Related issue number
Fixes #161
Checklist
Change does not change library functionality.