Skip to content

refactor: remove deploy/sdk #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

refactor: remove deploy/sdk #1929

wants to merge 2 commits into from

Conversation

biswapanda
Copy link
Contributor

@biswapanda biswapanda commented Jul 15, 2025 •
edited
Loading

Overview:

Remove deploy/sdk as this is not being used anymore.

🔴 waiting for multimodal examples to migrate off dynamo/sdk
2040

Details:

Closes: DYN-720

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Documentation

    • Removed all SDK documentation files, including comprehensive guides and quickstart examples.

  • New Features

    • None.

  • Bug Fixes

    • None.

  • Refactor

    • None.

  • Style

    • None.

  • Tests

    • Removed all test files, including unit, integration, and end-to-end tests.

  • Chores

    • Removed all SDK source files, CLI utilities, service definitions, decorators, resource management, and configuration modules.

  • Revert

    • None.

The SDK, its CLI, documentation, and all related tests have been fully removed from the repository. No user-facing features are available in this release.

@biswapanda biswapanda self-assigned this Jul 15, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025

Walkthrough

This change removes the entire Dynamo SDK CLI, core library, runtime, deployment, resource management, endpoint decorators, utility modules, and all associated documentation, tests, and Dockerfiles. All Python modules, CLI commands, and test scripts under the SDK are deleted, erasing the SDK's public API, CLI interface, service orchestration, and resource management code.

Changes

Files/Paths (Grouped) Change Summary
deploy/sdk/README.md, deploy/sdk/docs/cli/README.md, deploy/sdk/docs/sdk/README.md Remove documentation files and README references.
deploy/sdk/src/dynamo/sdk/init.py, .../core/init.py, .../core/protocol/init.py, .../lib/init.py Remove SDK and core module initializers and entry points.
deploy/sdk/src/dynamo/sdk/cli/* Remove all CLI modules: command definitions, resource allocator, circus integration, CLI runner, and utilities.
deploy/sdk/src/dynamo/sdk/core/decorators/endpoint.py Remove endpoint decorators, endpoint/client classes, and related abstractions.
deploy/sdk/src/dynamo/sdk/core/lib.py Remove core service registration, dependency injection, and health probe decorators/utilities.
deploy/sdk/src/dynamo/sdk/core/protocol/deployment.py Remove dataclasses for deployment resource, environment, and service specs.
deploy/sdk/src/dynamo/sdk/core/protocol/interface.py Remove all service, endpoint, dependency, and deployment target interfaces and validation logic.
deploy/sdk/src/dynamo/sdk/core/runner/* Remove runner, health check, service mixin, and local runtime implementation.
deploy/sdk/src/dynamo/sdk/lib/config.py, .../decorators.py, .../exceptions.py, .../image.py, .../loader.py, .../resource.py, .../utils.py Remove all library modules for config, decorators, exceptions, image, loader, resource, and utility functions.
deploy/sdk/src/dynamo/sdk/tests/* Remove all test modules, pipeline examples, config files, and end-to-end tests.
deploy/sdk/tests/test_deployment.sh Remove deployment shell test script.
deploy/sdk/src/dynamo/sdk/cli/Dockerfile.template Remove Dockerfile template for SDK CLI containerization.

Sequence Diagram(s)

No sequence diagram generated as the change is a comprehensive deletion of all code and control flow.

Possibly related PRs

Poem

Oh, what a sweep through the code today,
The CLI, the core, all whisked away!
No more endpoints, runners, or test parade—
The SDK's garden, now freshly laid.
But in the silence, new seeds may grow,
For every ending, a start we know.
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef59ac8 and 9ad7965.

📒 Files selected for processing (41)
  • deploy/sdk/README.md (0 hunks)
  • deploy/sdk/docs/cli/README.md (0 hunks)
  • deploy/sdk/docs/sdk/README.md (0 hunks)
  • deploy/sdk/src/dynamo/sdk/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/Dockerfile.template (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/allocator.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/circus.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/cli.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/env.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/run.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/run_executable.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/serve.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/serve_dynamo.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/serving.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/utils.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/decorators/endpoint.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/lib.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/protocol/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/protocol/deployment.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/protocol/interface.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/runner/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/runner/common.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/runner/dynamo.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/runner/health.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/config.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/decorators.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/exceptions.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/image.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/loader.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/resource.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/utils.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/config.yaml (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/pipeline.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_config.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_e2e_args.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_e2e_config.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_link.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_resources.py (0 hunks)
  • deploy/sdk/tests/test_deployment.sh (0 hunks)
💤 Files with no reviewable changes (41)
  • deploy/sdk/docs/sdk/README.md
  • deploy/sdk/src/dynamo/sdk/core/protocol/init.py
  • deploy/sdk/src/dynamo/sdk/core/init.py
  • deploy/sdk/src/dynamo/sdk/tests/config.yaml
  • deploy/sdk/src/dynamo/sdk/lib/init.py
  • deploy/sdk/docs/cli/README.md
  • deploy/sdk/src/dynamo/sdk/lib/image.py
  • deploy/sdk/src/dynamo/sdk/core/runner/init.py
  • deploy/sdk/src/dynamo/sdk/cli/run_executable.py
  • deploy/sdk/src/dynamo/sdk/cli/Dockerfile.template
  • deploy/sdk/src/dynamo/sdk/cli/run.py
  • deploy/sdk/src/dynamo/sdk/tests/test_resources.py
  • deploy/sdk/README.md
  • deploy/sdk/src/dynamo/sdk/tests/test_e2e_args.py
  • deploy/sdk/tests/test_deployment.sh
  • deploy/sdk/src/dynamo/sdk/tests/test_link.py
  • deploy/sdk/src/dynamo/sdk/init.py
  • deploy/sdk/src/dynamo/sdk/lib/utils.py
  • deploy/sdk/src/dynamo/sdk/tests/test_e2e_config.py
  • deploy/sdk/src/dynamo/sdk/core/protocol/deployment.py
  • deploy/sdk/src/dynamo/sdk/lib/config.py
  • deploy/sdk/src/dynamo/sdk/cli/cli.py
  • deploy/sdk/src/dynamo/sdk/cli/serve_dynamo.py
  • deploy/sdk/src/dynamo/sdk/lib/exceptions.py
  • deploy/sdk/src/dynamo/sdk/tests/pipeline.py
  • deploy/sdk/src/dynamo/sdk/cli/allocator.py
  • deploy/sdk/src/dynamo/sdk/core/runner/dynamo.py
  • deploy/sdk/src/dynamo/sdk/core/runner/health.py
  • deploy/sdk/src/dynamo/sdk/lib/decorators.py
  • deploy/sdk/src/dynamo/sdk/lib/loader.py
  • deploy/sdk/src/dynamo/sdk/core/decorators/endpoint.py
  • deploy/sdk/src/dynamo/sdk/tests/test_config.py
  • deploy/sdk/src/dynamo/sdk/core/runner/common.py
  • deploy/sdk/src/dynamo/sdk/core/lib.py
  • deploy/sdk/src/dynamo/sdk/cli/serving.py
  • deploy/sdk/src/dynamo/sdk/cli/circus.py
  • deploy/sdk/src/dynamo/sdk/lib/resource.py
  • deploy/sdk/src/dynamo/sdk/cli/serve.py
  • deploy/sdk/src/dynamo/sdk/cli/utils.py
  • deploy/sdk/src/dynamo/sdk/core/protocol/interface.py
  • deploy/sdk/src/dynamo/sdk/cli/env.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@biswapanda biswapanda closed this Jul 15, 2025
@biswapanda biswapanda reopened this Jul 16, 2025
@biswapanda biswapanda mentioned this pull request Jul 17, 2025
Merged
@nv-anants nv-anants mentioned this pull request Jul 23, 2025
Merged
@biswapanda biswapanda closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutm hutm Awaiting requested review from hutm hutm is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@julienmancuso julienmancuso Awaiting requested review from julienmancuso julienmancuso is a code owner

@hhzhang16 hhzhang16 Awaiting requested review from hhzhang16 hhzhang16 is a code owner

@nnshah1 nnshah1 Awaiting requested review from nnshah1 nnshah1 is a code owner

@mohammedabdulwahhab mohammedabdulwahhab Awaiting requested review from mohammedabdulwahhab mohammedabdulwahhab is a code owner

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4 rmccorm4 is a code owner

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25 tanmayv25 is a code owner

@richardhuo-nv richardhuo-nv Awaiting requested review from richardhuo-nv richardhuo-nv is a code owner

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV ptarasiewiczNV is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

Assignees

@biswapanda biswapanda

Labels
refactor size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@biswapanda