Skip to content

chore: Update CODEOWNERS #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

chore: Update CODEOWNERS #1380

merged 1 commit into from
Jun 6, 2025

Conversation

whoisj
Copy link
Collaborator

@whoisj whoisj commented Jun 4, 2025 •
edited by coderabbitai bot
Loading

This PR breaks the massive list of owners for the /examples/ folder into smaller groups for individual subfolders.

The selection of owners is based on git blame and identifying individuals based on the emails they attached to their commits.

The impetus for this PR is based on recent work I did in the /examples/ folder that added over 20 individuals, none of whom were interested in the PR.

Change also slips in adding myself (original author) of the /.github/workflows/ copyright checking tool.

Summary by CodeRabbit

  • Chores
    • Updated ownership assignments for multiple subdirectories under the examples directory to improve clarity.
    • Assigned ownership of the general examples directory to a specific team.
    • Added a new owner for certain GitHub workflow files.

@whoisj whoisj added the chore label Jun 4, 2025
@whoisj whoisj requested review from nnshah1 and a team as code owners June 4, 2025 18:10
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 4, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

👋 Hi whoisj! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added the external-contribution Pull request is from an external contributor label Jun 4, 2025
@whoisj whoisj changed the title Update CODEOWNERS chore: Update CODEOWNERS Jun 4, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 4, 2025 •
edited
Loading

Walkthrough

The CODEOWNERS file was updated to assign more granular ownership to individual subdirectories within /examples/ and to specify ownership for PowerShell workflow scripts under /.github/workflows/*.ps1. The general /examples/ directory ownership was assigned to @ai-dynamo/Devops, @nnshah1, @whoisj, and @rmccorm4. No changes were made to exported or public entities elsewhere in the codebase.

Changes

File(s) Change Summary
CODEOWNERS Replaced broad /examples/ ownership with specific owners for multiple /examples/ subdirectories; assigned /examples/ to @ai-dynamo/Devops, @nnshah1, @whoisj, and @rmccorm4; added ownership for /.github/workflows/*.ps1 to @whoisj

Sequence Diagram(s)

sequenceDiagram
    participant Contributor
    participant GitHub
    participant CODEOWNERS

    Contributor->>GitHub: Opens PR modifying /examples/llm/
    GitHub->>CODEOWNERS: Checks ownership rules
    CODEOWNERS-->>GitHub: Returns specific owners for /examples/llm/
    GitHub-->>Contributor: Requests review from listed owners
Loading

Possibly related PRs

Poem

In the warren of code, new rules take their place,
Each example now has its own bunny to chase.
Devops guards the burrow’s wide gate,
While PowerShell scripts find their mate.
With every hop, ownership’s clear—
A tidy warren, year after year! 🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e61ea5 and a5c9bec.

📒 Files selected for processing (1)
  • CODEOWNERS (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • CODEOWNERS
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test - vllm
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@whoisj whoisj force-pushed the whoisj/codeowners/refactor branch 2 times, most recently from 192c8c9 to 8f15d43 Compare June 4, 2025 18:31
@whoisj whoisj enabled auto-merge (squash) June 4, 2025 20:10
@whoisj whoisj removed the external-contribution Pull request is from an external contributor label Jun 4, 2025
rmccorm4
rmccorm4 reviewed Jun 4, 2025
View reviewed changes
@whoisj @rmccorm4
Update CODEOWNERS
a5c9bec 
This change breaks the massive list of owners for the /examples/ folder into smaller groups for individual subfolders.

This change reduces the top-level list of owners to the following:
- ai-dynamo/devops
- Neelay Shaw
- Ryan McCormick
- J Wyman

Co-authored-by: Ryan McCormick <mccormick.codes@gmail.com>
Signed-off-by: J Wyman <jeremy.wyman@outlook.com>
@whoisj whoisj force-pushed the whoisj/codeowners/refactor branch from 3e61ea5 to a5c9bec Compare June 6, 2025 18:01
@whoisj whoisj merged commit 2019a7d into ai-dynamo:main Jun 6, 2025
6 checks passed
@whoisj whoisj deleted the whoisj/codeowners/refactor branch June 9, 2025 16:11
This was referenced Jun 25, 2025
Merged
Merged
Merged
This was referenced Jul 8, 2025
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jul 16, 2025
Closed
@coderabbitai coderabbitai bot mentioned this pull request Jul 29, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Sep 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 left review comments

@nnshah1 nnshah1 nnshah1 approved these changes

Assignees
No one assigned
Labels
chore size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whoisj @nnshah1 @rmccorm4