fix!: [#4] Show overwrite warning for ahoy init
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2022 14:55
Shows a warning and a confirmation prompt when running `ahoy init` if an `.ahoy.yml` file already exists in the current directory and would otherwise be overwritten. BREAKING CHANGE: The warning prompt requires user input, so this may require updating of e.g. scripted calls to `ahoy init`. The prompt can be overruled by passing the "force" flag, e.g. `ahoy init --force`
added 2 commits
July 17, 2022 17:07
Also theoretically improve cross platform testing, and replace deprecated `ioutil.*` functions as required.
AlexSkrypnyk
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
@ocean
LGTM
Could you please update the description of the PR to explicitly explain if the message is still shown if the --force is passed.
|
@AlexSkrypnyk Ok cool. A warning message is still shown if you pass the Do you reckon I should remove that or still have it? |
|
@ocean |
|
@ocean please feel free to merge at your earliest convenience. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4
Shows a warning and a confirmation prompt when running
ahoy initif an
.ahoy.ymlfile already exists in the current directory andwould otherwise be overwritten.
BREAKING CHANGE: The warning prompt requires user input, so this may
require updating of e.g. scripted calls to
ahoy init. The promptcan be overruled by passing the "force" flag, e.g.
ahoy init --forceIf the
--forceflag is passed, theinitcommand goes ahead, but a warning message is still shown:"Warning: '--force' parameter passed, overwriting .ahoy.yml in current directory.".