ci: test that generated files are up-to-date #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An added advantage is that downstream users inadverntantly loading `//:__pkg__` don't incur a dependency on Gazelle. That should not happen during regular usage, but can happen when users query `@rules_zig`, e.g. for debugging purposes. The dependency on Gazelle can lead to confusing error messages instead of useful output.
6c0a6f0 to
f54ca66
Compare
The `sh_binary` rule has multiple outputs such that `$(location )` expansion doesn't properly work on it.
99db814 to
21ca5c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
Creates a single executable target for all needed update steps.
Requires the multirun rule set.
Moves Gazelle into
//util.Moves
all_filesinto//utiland defines a Bazel target for it.Adds a test to the CI setup that all generate files are up-to-date.