Skip to content

feat: support manifest based runfiles lookup #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Feb 9, 2024
Merged

feat: support manifest based runfiles lookup #214

merged 25 commits into from
Feb 9, 2024

Conversation

aherrmann
Copy link
Owner

Part of #86

  • Integration test for runfiles
  • Integration test for runfiles manifest
  • update generated files
  • Factor out runfiles discovery
  • factor out var names and suffixes
  • Factor out realpath conversion
  • runfiles-discovery: more general interface
  • discoverRunfiles returns Location
  • Implement general runfiles discovery
  • Unit tests for runfiles discovery
  • Accept runfiles discovery options at create
  • Named DiscoverOptions type
  • Factor out directory based runfiles lookup
  • Unit test for directory based lookup
  • Factor out rpath splitting
  • update generated files
  • PRath HashMapContext
  • Implement manifest based runfiles strategy
  • Support manifest based runfiles lookup
  • Add unit tests for Runfiles
  • Avoid name Self
  • Document --nobuild_runfile_manifests behavior

@aherrmann
Integration test for runfiles
eeba54c
@aherrmann
Integration test for runfiles manifest
bd9bf8c
@aherrmann
update generated files
dc5bb17
@aherrmann
Factor out runfiles discovery
e08bd79
@aherrmann
factor out var names and suffixes
356dcd1
@aherrmann
Factor out realpath conversion
81fb8ba
@aherrmann
runfiles-discovery: more general interface
f5ce7dc
@aherrmann
discoverRunfiles returns Location
fdaace0
@aherrmann
Implement general runfiles discovery
972b7b4
@aherrmann
Unit tests for runfiles discovery
559dc77
@aherrmann
Accept runfiles discovery options at create
a36bc68
@aherrmann
Named DiscoverOptions type
15d4f4e
@aherrmann
Factor out directory based runfiles lookup
8b86f4b
@aherrmann
Unit test for directory based lookup
0f0f729
@aherrmann
Factor out rpath splitting
029c203 
With repo remapping in play, since Bazel 6 and bzlmod, we need to
consider the repository and path components of an rpath separately. This
is particularly relevant for the manifest based runfiles strategy where
we need to look up runfiles paths in a key-value mapping. If we were to
use simple strings as keys in this mapping then a runfiles lookup that
involves remapping would always require an extra allocation to construct
the new runfiles path with the remapped repository. This is unnecessary,
if we simply consider the repository and path component separately, then
we can avoid this extra allocation.
@aherrmann
update generated files
71f55ce
@aherrmann
PRath HashMapContext
75cf7a0
@aherrmann
Implement manifest based runfiles strategy
3b87fb2
@aherrmann
Support manifest based runfiles lookup
8d6ee88
@aherrmann
Add unit tests for Runfiles
4d18624
@aherrmann
Avoid name Self
e45fc41 
Use more descriptive names to bind `This()`.
@aherrmann
Document --nobuild_runfile_manifests behavior
86fea78 
It also disables the runfiles directory generation.
@aherrmann aherrmann enabled auto-merge February 9, 2024 17:13
@aherrmann
Return null if not found in manifest
a4d3fae 
This makes it easier to properly handle the case when the repo mapping
file does not exist.
@aherrmann
Avoid redundant fs.access
3a0605b
@aherrmann
Define constant for _repo_name
2e8797a
@aherrmann aherrmann merged commit 3fd56ec into main Feb 9, 2024
@aherrmann aherrmann deleted the runfiles branch February 9, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aherrmann