Skip to content

feat: implicit bazel_builtin package dependency #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 4, 2024
Merged

feat: implicit bazel_builtin package dependency #211

merged 13 commits into from
Feb 4, 2024

Conversation

aherrmann
Copy link
Owner

rules_zig automatically generates a bazel_builtin Zig module for every rules_zig target (from zig_binary to zig_package). The bazel_builtin module contains Bazel specific information such as the current repository name or the current target name.

  • Implement bazel_builtin_package action
  • Automatic dependency on bazel_builtin
  • Remove unused --pkg-begin --pkg-end flags
  • Add internal support for Zig package remapping
  • Remap bazel_builtin to "bazel_builtin"
  • e2e test for bazel_builtin module
  • Test bazel_builtin in package dependency
  • Create and depend on bazel_builtin template
  • Use expand_template to generate bazel_builtin
  • Add docstrings to bazel_builtin
  • Document bazel_builtin
  • Update package info test
  • Update generated files

@aherrmann
Implement bazel_builtin_package action
6178d8a 
Generate an automatic package that every target depends on providing
information specific to the target in the Bazel build.
@aherrmann
Automatic dependency on bazel_builtin
79fb25c
@aherrmann
Remove unused --pkg-begin --pkg-end flags
66c790e 
These were removed when the Zig compiler switched to the `--mod` flags.
@aherrmann
Add internal support for Zig package remapping
928ca14
@aherrmann
Remap bazel_builtin to "bazel_builtin"
aec4e25
@aherrmann
e2e test for bazel_builtin module
497241e
@aherrmann
Test bazel_builtin in package dependency
97eaf45
@aherrmann
Create and depend on bazel_builtin template
9d9eb2c
@aherrmann
Use expand_template to generate bazel_builtin
314717e
@aherrmann
Add docstrings to bazel_builtin
6225abf
@aherrmann
Document bazel_builtin
b64306d
@aherrmann
Update package info test
4cda84a 
To take the flags and input files for the respective bazel_builtin
modules into account.
@aherrmann
Update generated files
2181f6d
@aherrmann aherrmann enabled auto-merge February 4, 2024 19:42
@aherrmann aherrmann mentioned this pull request Feb 4, 2024
Merged
@aherrmann aherrmann merged commit 5b2b65b into main Feb 4, 2024
@aherrmann aherrmann deleted the bazel_builtin branch February 4, 2024 20:11
@aherrmann
Copy link
Owner Author

Some tests failed with errors of the form

Failed to fetch blobs because they do not exist remotely.: Missing digest: cb2b8ad6616eddb7d33a9da8430377eb3dfa548fc84571de91ecd6867e320c75/7432

This seems to be an instance of bazelbuild/bazel#18696.
The workaround was to clear the GitHub actions cache, which is effectively causing to the suggested bazel clean.
This can be done using the GitHub CLI with

# Identify the relevant caches
$ gh cache list -L60
# Delete the relevant caches
$ gh cache delete XXXX
$ gh cache delete YYYY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aherrmann