generated from bazel-contrib/rules-template
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: support zig_shared_library as cc_* dependency #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request a platform for which there is certainly no cc-toolchain registered.
These caused runtime errors of the following form with remote execution enabled. ``` /buildbuddy-execroot/bazel-out/k8-fastbuild/bin/cc-dependencies/shared-library/add-test.runfiles/_main/cc-dependencies/shared-library/add-test: Relink `/buildbuddy-execroot/bazel-out/k8-fastbuild/bin/cc-dependencies/shared-library/add-test.runfiles/_main/cc-dependencies/shared-library/../../_solib_k8/_U_S_Scc-dependencies_Sshared-library_Cadd___Ucc-dependencies_Sshared-library/libadd.so' with `/lib/x86_64-linux-gnu/libm.so.6' for IFUNC symbol `cosf' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to provide a
cc_shared_library
target as a dependency of acc_library|binary|test
target (or similar).To that end
cc_shared_library
emits aCcInfo
provider that captures the generated dynamic library. However, Bazel's CC API requires a CC toolchain to generated aCcInfo
for a dynamic library.cc_shared_library
registers an optional dependency on a CC toolchain. TheCcInfo
is only emitted if that CC toolchain dependency is filled.Adds e2e and analysis tests for direct and transitive Zig shared library dependencies of CC targets and tests that the CC toolchain dependency is indeed optional.