Skip to content

fix(docs): fix broken links and update content #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 24, 2025
Merged

fix(docs): fix broken links and update content #123

merged 4 commits into from
Jun 24, 2025

Conversation

keraron
Copy link
Member

@keraron keraron commented Jun 23, 2025

Fixes #121.

@keraron keraron requested a review from a team as a code owner June 23, 2025 16:57
@keraron keraron requested review from aduminuc and lgecse and removed request for a team June 23, 2025 16:57
@keraron
fix(documentation): fix broken links and update content according to …
beffde2 
…agent record renaming

Signed-off-by: Aron Kerekes <arkereke@cisco.com>
@lgecse lgecse mentioned this pull request Jun 23, 2025
Closed
@lgecse lgecse requested review from ramizpolic, a team and aduminuc and removed request for aduminuc June 23, 2025 17:02
@ramizpolic ramizpolic changed the title fix(documentation): fix broken links and update content according to … fix(docs): fix broken links and update content Jun 23, 2025
ramizpolic
ramizpolic approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, added minor nits

keraron and others added 2 commits June 23, 2025 20:07
@keraron @ramizpolic
Update docs/how-to-guides/bridge-howto.md
3c629ad 
Co-authored-by: Ramiz Polic <rpolic@cisco.com>
Signed-off-by: Aron Kerekes <arkereke@cisco.com>
@keraron @ramizpolic
Update docs/oasf/oasf-server.md
ae56a12 
Co-authored-by: Ramiz Polic <rpolic@cisco.com>
Signed-off-by: Aron Kerekes <arkereke@cisco.com>
@muscariello muscariello self-requested a review June 24, 2025 07:07
muscariello
muscariello requested changes Jun 24, 2025
View reviewed changes
Copy link
Member

@muscariello muscariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still broken links

In mkdocs all references to source files are brokens. Same for Edit links.

@keraron
fix(documentation): further broken link fixes, fixing edit and view s…
54c5677 
…ource buttons

Signed-off-by: Aron Kerekes <arkereke@cisco.com>
muscariello
muscariello approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@muscariello muscariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@keraron keraron merged commit 5539e54 into main Jun 24, 2025
5 checks passed
@keraron keraron deleted the mkdocs_fixes_2 branch June 24, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muscariello muscariello muscariello approved these changes

@lgecse lgecse Awaiting requested review from lgecse

@aduminuc aduminuc Awaiting requested review from aduminuc

@ramizpolic ramizpolic Awaiting requested review from ramizpolic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken links and update changed names
3 participants
@keraron @muscariello @ramizpolic