Skip to content

Feature implementation: Commenting system for posts #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 14, 2020
Merged

Feature implementation: Commenting system for posts #8

merged 14 commits into from
Nov 14, 2020

Conversation

theagora
Copy link
Contributor

@theagora theagora commented Nov 14, 2020 •
edited
Loading

Feature proposal v2: #3 (comment)

  • Blog readers can COMMENT on each post
  • 1-category-1-issue
  • 1-category-1-page

@theagora
create 'Comment' module/function to add new comment
022eafc 
quote from location.href, if eligible, for the new comment
@theagora
create Category (muitinⒾ) Comments page
9fd315f 
Github issue page: /issues/5
@theagora
create Category (srettaⓂ) Comments page
638b456 
Github issue page: /issues/6
@theagora
create Category (sucoⓋ) Comments page
3d9090a 
Github issue page: /issues/7
@theagora
add emoji link to Category Comments pages
e21efcd 
pass post titles and urls to the destination location.href
@theagora theagora added the enhancement New feature or request label Nov 14, 2020
@theagora theagora requested a review from neruthes November 14, 2020 00:41
@theagora theagora self-assigned this Nov 14, 2020
andyof
andyof approved these changes Nov 14, 2020
View reviewed changes
Copy link

@andyof andyof left a comment •
edited by theagora
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-done flow:

  • front page -> category comments -> new comment

Expected flows:

  • category page <-> category comments
  • post page -> new comment

This was linked to issues Nov 14, 2020
New Features Wishlist #3
Open
Comments on INITIUM Posts 💬 #5
Closed
Comments on MATTERS Posts 💬 #6
Closed
Comments on VOCUS Posts 💬 #7
Closed
@theagora theagora marked this pull request as draft November 14, 2020 06:52
@theagora
Copy link
Contributor Author

theagora commented Nov 14, 2020 •
edited
Loading

Feature proposal v2: #3 (comment)

  • Blog readers can COMMENT on each post
  • 1-category-1-issue
  • 1-category-1-page

Update: Feature proposal v2.1: #3 (comment)

  • front page -> category comments
  • category comments -> new comment
  • category page <-> category comments

@theagora theagora marked this pull request as ready for review November 14, 2020 08:17
andyof and others added 2 commits November 14, 2020 17:28
@andyof
Update README with Feature proposal v2 (/issues/3)
27d55d2 
Specs of feature proposal v2: #3 (comment)
@theagora
Merge pull request #1 from andyof/patch-2
f9cbb8b 
Update README with Feature proposal v2 (/issues/3)
andyof
andyof reviewed Nov 14, 2020
View reviewed changes
@theagora theagora merged commit 0f22d39 into agorahub:master Nov 14, 2020
@theagora theagora mentioned this pull request Nov 14, 2020
Open
1 task
@theagora theagora deleted the theagora-patch-1 branch November 14, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neruthes neruthes Awaiting requested review from neruthes

1 more reviewer

@andyof andyof andyof approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@theagora theagora

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Features Wishlist Comments on VOCUS Posts 💬 Comments on MATTERS Posts 💬 Comments on INITIUM Posts 💬
2 participants
@theagora @andyof