Skip to content

Clauses of projection-like functions not quoted correctly #5142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2021
Merged

Clauses of projection-like functions not quoted correctly #5142

merged 3 commits into from
Jan 19, 2021

Conversation

UlfNorell
Copy link
Member

Fixes #5128

@UlfNorell UlfNorell requested a review from jespercockx January 18, 2021 14:42
jespercockx
jespercockx approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@jespercockx jespercockx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, it's the projection-like optimization that was behind it. Thanks for fixing this!

@UlfNorell UlfNorell added the status: work-in-progress Do not merge ATM label Jan 18, 2021
@UlfNorell
Copy link
Member Author

Not quite working yet it seems. Test case for #2226 fails, some interaction with instance-opened modules.

@UlfNorell UlfNorell removed the status: work-in-progress Do not merge ATM label Jan 19, 2021
@UlfNorell UlfNorell merged commit 7f8b193 into master Jan 19, 2021
@UlfNorell UlfNorell deleted the issue5128 branch January 19, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespercockx jespercockx jespercockx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getDefinition sometimes loses patterns
2 participants
@UlfNorell @jespercockx