Inspect DMARC reports and tag the message #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMARC reports usually come in ZIP files. To check the report you have to unpack and search thru XML document which is very tedious. The filter tags the message as follows: - if there's any SPF failure in any attachment, tag the message with "dmarc-spf-fail" tag, otherwise tag with "dmarc-spf-ok" - if there's any DKIM failure in any attachment, tag the message with "dmarc-dkim-fail" tag, otherwise tag with "dmarc-dkim-ok"
|
Hey @aidecoe thank you for the patch |
|
Why I am the author of that commit? That looks wrong o.O |
|
Be careful @andir it's a trap we will ask you to come back on the project ! 🍺 |
|
But I think you are just the first maintainer to validate the review so GH take the first one |
andir
pushed a commit
that referenced
this pull request
Dec 4, 2017
Inspect DMARC reports and tag the message
|
@aidecoe I removed myself from the |
|
@andir Yes it is automatically added when you review so, joke aside not a big deal, You can reply instead of approving if don't want your name in the commit 🍺 😄 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMARC reports usually come in ZIP files. To check the report you have to
unpack and search thru XML document which is very tedious. The filter
tags the message as follows:
"dmarc-spf-fail" tag, otherwise tag with "dmarc-spf-ok"
"dmarc-dkim-fail" tag, otherwise tag with "dmarc-dkim-ok"