Skip to content

Unify utf-8 comments, SPDX-License-Identifier, cleanup shebangs #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2017
Merged

Unify utf-8 comments, SPDX-License-Identifier, cleanup shebangs #171

merged 5 commits into from
Nov 28, 2017

Conversation

flokli
Copy link
Member

@flokli flokli commented Nov 28, 2017

This uses a consistent utf-8 coding style comment, uses SPDX-License-Identifier instead of the full license quote (preserving copyright notices). and removes an unnecessary shebang in afew.commands.

GuillaumeSeren
GuillaumeSeren reviewed Nov 28, 2017
View reviewed changes
Copy link
Collaborator

@GuillaumeSeren GuillaumeSeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeSeren
Copy link
Collaborator

Hey @flokli
I've seen you use that shortened licence on an other PR,
I think it is nice, because take less space in files.

I checked the diff looks ok,

We also should add a (global) licence file to the project,
because GitHub seems to no detect it well, and so not display it,
maybe also adding a small mention in the README that way it is clear for everyone.

@flokli flokli force-pushed the cleanups branch 3 times, most recently from 1ee0631 to 45db38b Compare November 28, 2017 20:47
@flokli
Copy link
Member Author

flokli commented Nov 28, 2017

Added a LICENSE file, together with updated information in setup.py.
It might be ISC is not directly detected by github, but IMHO this is now already pretty clear.

@flokli flokli mentioned this pull request Nov 28, 2017
Merged
@andir
Copy link
Member

andir commented Nov 28, 2017

LGTM.

@andir andir merged commit 1cf20d5 into afewmail:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeSeren GuillaumeSeren GuillaumeSeren left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flokli @GuillaumeSeren @andir