Skip to content

Do healthcheck more frequently at startup #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2025
Merged

Do healthcheck more frequently at startup #4292

merged 5 commits into from
Apr 30, 2025

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Mar 9, 2024

This PR is supported by the Æternity Foundation

Before this PR:

$ docker compose up node -d --wait
[+] Running 1/1
 ✔️ Container aepp-sdk-js-node-1  Healthy 30.9s

With --start-period=10s --start-interval=2s:

$ docker compose up node -d --wait
[+] Running 1/1
 ✔️ Container aepp-sdk-js-node-1  Healthy 3.4s

With --start-period=5s --start-interval=1s:

$ docker compose up node -d --wait
[+] Running 1/1
 ✔️ Container aepp-sdk-js-node-1  Healthy 3.2s

https://docs.docker.com/reference/dockerfile/#healthcheck
related aeternity/aesophia_http#133

davidyuk added 2 commits March 9, 2024 15:19
@davidyuk
Move retries from healthcheck.sh to dockerfile
a57c153 
To don't be confusing because docker does 3 healthcheck retries by default.
@davidyuk
Healthcheck more frequently at startup
e63db2a
@dincho
Copy link
Member

dincho commented Mar 11, 2024

Please note:

start interval is the time between health checks during the start period. This option requires Docker Engine version 25.0 or later.

That's a bit on the edge :)

@davidyuk davidyuk mentioned this pull request Mar 12, 2024
Merged
@davidyuk
Copy link
Member Author

Ok, let's wait a bit then. I found a workaround:

    healthcheck:
      interval: 2s

in docker-compose.yml

@davidyuk davidyuk mentioned this pull request Mar 13, 2024
Closed
@davidyuk davidyuk mentioned this pull request May 9, 2024
Merged
dincho
dincho previously approved these changes Apr 29, 2025
View reviewed changes
@dincho dincho merged commit f6d7021 into aeternity:master Apr 30, 2025
39 checks passed
@davidyuk davidyuk deleted the speedup-healthy branch April 30, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dincho dincho dincho approved these changes

+1 more reviewer

@thepiwo thepiwo thepiwo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidyuk @dincho @thepiwo