Fix big-endian binary stl reading #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0eda515 to
5431ce4
Compare
Also use uint32_t instead of int for header_num_facets as per the binary STL spec.
5431ce4 to
ca21b35
Compare
|
Thanks for you contribution. However, this doesn't compile on Mac, and it produces some errors with |
|
@hroncok Could you fetch again? I think I've already fixed them. |
|
I'm not fetching, I'm watching the Travis CI integration here. |
|
Oh oops, looks like a different error from the one I fixed. I'll have a look, thanks. |
Looks like Apple has no <endian.h>
19a84aa to
d2c9f2a
Compare
Fixes this warning: src/portable_endian.h:1:1: error: C++ style comments are not allowed in ISO C90 [-Werror]
31e203b to
8c8d0df
Compare
|
@hroncok It's green now. |
|
Great job! Do you need this to be included in the 0.98.x series, or merging to master and released "when ready" is fine? |
|
On Sun, Oct 01, 2017 at 04:54:02AM -0700, Miro Hrončok wrote:
Great job! Do you need this to be included in the 0.98.x series, or merging to
master and released "when ready" is fine?
Thanks. I think merging to master and released when ready is fine, but having
this in the 0.98.x would be nice to have as well.
…--
Kind regards,
Loong Jin
|
hyperair
added a commit
to hyperair/Slic3r
that referenced
this pull request
Oct 1, 2017
Partially revert 2085a48. This is in preparation for applying the upstream fix from admesh at admesh/admesh#26
hyperair
added a commit
to hyperair/Slic3r
that referenced
this pull request
Oct 1, 2017
hyperair
added a commit
to hyperair/Slic3r
that referenced
this pull request
Oct 1, 2017
lordofhyphens
pushed a commit
to slic3r/Slic3r
that referenced
this pull request
Oct 1, 2017
|
This has slipped from my radar. I'll merge today. |
|
Let's keep this in master for a while before it's merged to 0.98.x. |
hroncok
pushed a commit
to hroncok/admesh
that referenced
this pull request
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a deserialization issue (all floats end up wrong) that occurs when reading binary STLs on a big-endian machine, e.g. powerpc.