Allow to set pull request custom title and body #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelschiff
approved these changes
Jun 29, 2023
kzadorozhny
approved these changes
Jul 1, 2023
|
Hello, do you think we could have this merged and released soon? |
|
Sorry for the delay, thank you again for the contribution! |
|
No problem, thank you @michaelschiff! :) |
|
@michaelschiff Could you also please tag a new release with this addition? |
arturo-skydio
pushed a commit
to Skydio/rules_gitops
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We are using your GitOps rules and would like to add some arguments to the
@com_adobe_rules_gitops//gitops/prer:create_gitops_prsin order to allow settings a custom title and/or body pull request.Description
By default, it continues to act as it is for now by settings the following as title and body:
GitOps deployment <branch>, but you can also specify:-gitops_pr_title "<your pull request title>"-gitops_pr_body "<your pull request body>"This would be useful for us in order to display a changelog in the pull request body.
Related Issue
#136
Motivation and Context
We would like to add custom information to the pull request such as a changelog.
How Has This Been Tested?
I've tested it by forking the project and using it in my Bazel project.
Types of changes
Checklist: