Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typescript declaration files on packages
Fix typescript issues of sample app
AEPSampeApp
Description
Fix typescript declaration files on packages
Fixed fields
main
and addtypes
fields topackage.json
files ofpackages/*
, example:file: packages/campaignclassic/package.json
current
fixed
Fix typescript issues of sample app
AEPSampeApp
null
valuestypes/props.ts
Related Issue
It fixes the issue 353.
How to reproduce
Clone the repo
adobe/aepsdk-react-native
and compile the typescript ofapps/AEPSampleApp
;Motivation and Context
This is causing issues for consumers that has the option
strictNullChecks:true
on their tsconfig when they update to the version 6.0.0 described on the issue 353. This is blocking the consumers to upgrade the library or forcing them to change their tsconfig.The root cause is that the package.json files from all the packages, contain the typescript file itself on
main
field, rather than javascript and declaration files as described on typescript documentation.current
changed
The bug is also in the sample app of the
aepsdk-react-native
repo itself when running the commandnpx tsc
ataepsdk-react-native/apps/AEPSampleApp
.How Has This Been Tested?
The changes were tested by:
npm run test
npx tsc
command ataepsdk-react-native/apps/AEPSampleApp
Screenshots (if appropriate):
Types of changes
Checklist: