Security and contribution clarifications #2381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timo and Andreas haven't contributed in years.
Also: fix BucketIT file name.
There was a problem hiding this comment.
Pull Request Overview
The purpose of the PR is to update documentation for security and contribution clarifications.
- Removed outdated developer entries from pom.xml.
- Added new sections in README.md for Governance model, Vulnerability reports, and Security.
- Updated the CONTRIBUTING.md file to require test coverage for submissions.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.xml | Removed obsolete developer entries to reflect current project leads. |
| README.md | Added documentation sections for governance, vulnerability reports, and security; updated integration test reference. |
| .github/CONTRIBUTING.md | Updated contribution guidelines to include test requirements. |
Comments suppressed due to low confidence (2)
pom.xml:44
- [nitpick] The removal of developer entries appears intentional; please ensure that the updated list of project maintainers is consistently reflected in all related documentation.
- <developer> ... </developer>
README.md:278
- Please confirm that the updated integration test reference ('BucketIT') is correct and consistent with the actual test file name, given the previous reference was 'BucketV2IT'.
See [`BucketIT`](integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/BucketIT.kt) as an example on how it's used in the code.
d6f4e93 to
b5750e9
Compare
S3Mock includes a self-signed SSL certificate which must be accepted by any client accessing S3Mock. Fixes #281
b5750e9 to
bb66f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only documentation changes.
Related Issue
N/A
Tasks