Support crc64nvme checksum #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74c286f to
635347f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new crc64nvme checksum along with corresponding tests and refactors components to use the updated checksum types from AWS SDK v2.
- Added support for crc64nvme in header parsing and checksum calculations.
- Updated interfaces and tests to use DefaultChecksumAlgorithm and the new conversion methods.
- Minor adjustments in changelog and ancillary integrations.
Reviewed Changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| server/src/main/java/com/adobe/testing/s3mock/util/HeaderUtil.java | Adds header check for crc64nvme checksum |
| server/src/main/java/com/adobe/testing/s3mock/util/DigestUtil.java | Adapts checksum utility to use updated checksum algorithm types |
| server/src/main/java/com/adobe/testing/s3mock/store/MultipartStore.java | Changes multipart upload checksum conversion to use new method |
| server/src/main/java/com/adobe/testing/s3mock/service/ServiceBase.java | Adds handling for crc64nvme checksum in checksum verification |
| server/src/main/java/com/adobe/testing/s3mock/dto/ChecksumAlgorithm.java | Refactors algorithm enum mapping to new DefaultChecksumAlgorithm |
| server/src/main/java/com/adobe/testing/s3mock/dto/Checksum.java | Adds new crc64nvme field (potential formatting issue in JSON property) |
| integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/AclIT.kt | Removes variable assignment for grantee email leaving a stray literal |
| Remaining integration tests | Refactor checksum tests to use DefaultChecksumAlgorithm consistently |
| CHANGELOG.md | Updates dependency versions and related metadata changes |
Files not reviewed (2)
- pom.xml: Language not supported
- server/pom.xml: Language not supported
Comments suppressed due to low confidence (1)
integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/AclIT.kt:111
- A stray string literal appears to replace the variable assignment for granteeEmail. Consider restoring the assignment (e.g., 'val granteeEmail = "jane@doe.com"') or removing the unused literal if not required.
"jane@doe.com"
server/src/main/java/com/adobe/testing/s3mock/dto/Checksum.java
Outdated
Show resolved
Hide resolved
Also migrate to new ChecksumAlgorithm related types from AWS SDK v2. Fixes #2334
635347f to
dd97462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support crc64nvme checksum, add tests.
Refactor S3Mock and tests to use new checksum related types from AWS SDK v2.
Related Issue
#2334
Tasks