Add Kotlin SDK ITs, simplifications #2308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Use new Kotlin SDK for ITs Use simplified Kotlin builder syntax in tests
bb419a7 to
b1d7916
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the integration tests to use the new Kotlin SDK and simplified Kotlin builder syntax for S3 operations. Key changes include:
- Updating all S3 client and request builder invocations to use Kotlin DSL lambda style.
- Renaming credential variables consistently to s3AccessKeyId and s3SecretAccessKey.
- Introducing a new createS3ClientKotlin function for the Kotlin SDK and adding a new IT file.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/S3TestBase.kt | Refactor of S3 client creation and request builders using Kotlin DSL, plus variable renaming. |
| integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/KotlinSDKIT.kt | New integration test using the new Kotlin SDK. |
| integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/AclITV2.kt | Updated bucket and ACL operations to leverage Kotlin DSL. |
Files not reviewed (2)
- integration-tests/pom.xml: Language not supported
- pom.xml: Language not supported
Comments suppressed due to low confidence (1)
integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/S3TestBase.kt:288
- [nitpick] The nested let chain used for constructing 'normalizedName' may reduce readability. Consider refactoring this block by introducing intermediary variables to improve clarity.
val normalizedName = testInfo.testMethod.get().name.let {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use new Kotlin SDK for ITs
Use simplified Kotlin builder syntax in tests
Related Issue
N/A
Tasks