Verify object tagging #2473

afranken · 2025-06-23T22:41:03Z

Description

Tags are now verified for correctness.

N/A

server/src/main/java/com/adobe/testing/s3mock/service/ObjectService.java

Includes minor fixes.

Copilot

This PR adds server-side validation for S3 object tags, introduces a new INVALID_TAG exception, and updates related tests and documentation.

Implements verifyObjectTags in ObjectService and calls it in the controller
Defines INVALID_TAG in S3Exception and adds unit tests covering various tag validation scenarios
Renames writeVersionsfile to writeVersionsFile in ObjectStore and applies minor metadata updates

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
server/src/main/java/com/adobe/testing/s3mock/service/ObjectService.java	Add `verifyObjectTags` and helper methods for tag validation
server/src/main/java/com/adobe/testing/s3mock/S3Exception.java	Add `INVALID_TAG` exception constant
server/src/main/java/com/adobe/testing/s3mock/ObjectController.java	Call `verifyObjectTags` before applying tags
server/src/main/java/com/adobe/testing/s3mock/store/ObjectStore.java	Rename `writeVersionsfile` → `writeVersionsFile` and null checks
server/src/main/java/com/adobe/testing/s3mock/store/S3ObjectMetadata.java	Annotate `deleteMarker`’s `versionId` parameter as `@Nullable`
server/src/test/kotlin/com/adobe/testing/s3mock/service/ObjectServiceTest.kt	Add tests for valid/invalid tag lists
README.md	Fix typos, headings, wording, and add "Powered by" section
CHANGELOG.md	Document tag verification feature and minor version bumps

Comments suppressed due to low confidence (5)

server/src/test/kotlin/com/adobe/testing/s3mock/service/ObjectServiceTest.kt:314

[nitpick] Test name refers to 'store tags' but the method under test is verifyObjectTags; consider renaming to 'verify tags succeeds' for clarity.

  fun `store tags succeeds`() {

server/src/test/kotlin/com/adobe/testing/s3mock/service/ObjectServiceTest.kt:334

[nitpick] Add boundary tests for exactly MAX_ALLOWED_TAGS (50) and just above (51) to ensure edge conditions are handled correctly.

    for (i in 0..60) {

server/src/main/java/com/adobe/testing/s3mock/store/ObjectStore.java:518

[nitpick] The method name writeMetafile is inconsistent with writeVersionsFile; consider renaming to writeMetaFile for consistent camel-case.

        writeMetafile(bucket, S3ObjectMetadata.deleteMarker(s3ObjectMetadata, versionId));

server/src/main/java/com/adobe/testing/s3mock/store/S3ObjectMetadata.java:79

Make sure the correct @Nullable import (e.g., org.jspecify.annotations.Nullable) is present to avoid compilation errors.

  public static S3ObjectMetadata deleteMarker(S3ObjectMetadata metadata, @Nullable String versionId) {

README.md:576

[nitpick] Consider splitting this sentence or replacing the comma with a semicolon to avoid a run-on sentence.

`S3Mock` dependencies are updated regularly, any update could break any number of projects.

github-advanced-security bot found potential problems Jun 23, 2025

View reviewed changes

afranken force-pushed the verify-object-tagging branch 2 times, most recently from 9c312f3 to d07e22d Compare June 27, 2025 12:24

afranken requested a review from Copilot June 27, 2025 12:35