Nullability annotations, JavaDoc, refactorings #2456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dc3443 to
2b59753
Compare
The API doc and function signatures describe what the functions do, let's describe what they do differently from what is described in the API instead of stating the obvious.
f389f23 to
8a57dcb
Compare
The API doc and function signatures describe what the functions do, let's describe what they do differently from what is described in the API instead of stating the obvious.
The API doc and function signatures describe what the functions do, let's describe what they do differently from what is described in the API instead of stating the obvious.
44243bb to
d4abaf6
Compare
d4abaf6 to
466f8ef
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up JavaDoc formatting, adds JSpecify @nullable annotations for improved nullability handling, and refactors several API methods and unit tests (including migrating tests to Kotlin).
- Improved JavaDocs with more concise API references
- Added JSpecify nullability annotations and removed Spring-specific annotations
- Refactored tests to utilize Kotlin naming conventions and updated the build configuration
Reviewed Changes
Copilot reviewed 81 out of 81 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/main/java/com/adobe/testing/s3mock/dto/* | Added @nullable annotations in enum fromValue methods |
| server/src/main/java/com/adobe/testing/s3mock/ObjectController.java | Updated JavaDocs and added @nullable to request parameters |
| server/src/main/java/com/adobe/testing/s3mock/MultipartController.java | Refactored test method names and updated tagging tests |
| server/src/main/java/com/adobe/testing/s3mock/BucketController.java | Updated JavaDocs and modified region resolution logic |
| pom.xml and server/pom.xml | Added jspecify dependency and configuration updates |
| integration-tests/...ObjectTaggingIT.kt | Updated integration tests with Kotlin idioms |
| README.md and CHANGELOG.md | Updated documentation per new API changes |
Comments suppressed due to low confidence (1)
server/src/main/java/com/adobe/testing/s3mock/BucketController.java:373
- Removing the fallback to 'region.toString()' may lead to a null value for bucketRegion if bucketMetadata.bucketRegion() is null. Consider restoring the fallback to ensure LocationConstraint is never constructed with null.
String bucketRegion = bucketMetadata.bucketRegion();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
N/A
Tasks