Re-enable dependency based JRE #2434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
f75f5fc to
211294e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
It looks like this was finally fixed in a JRE 21 patch version
211294e to
8bd087c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables the dependency-based JRE build by updating the Dockerfile to work with a Java 21 patch release.
- Update jdeps command parameters to target Java 21 and adjust the classpath format.
- Modify the jlink invocation to incorporate the dynamically determined module dependencies and include jdk.crypto.ec.
Comments suppressed due to low confidence (2)
docker/Dockerfile:49
- Ensure that the output of 'jre-deps.info' is never empty and produces a properly formatted, comma-separated module list. If it might be empty, consider adding a check or a default module set to avoid a leading comma.
--add-modules $(cat jre-deps.info),jdk.crypto.ec \
docker/Dockerfile:60
- [nitpick] Consider removing outdated commented code if it is no longer relevant to improve clarity and reduce confusion in the Dockerfile.
#TODO: activate copy from builder stage when jdeps works again...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like this was finally fixed in a JRE 21 patch version
Related Issue
N/A
Tasks